Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

versionsMapping = mapOf("coroutines" to "org.getbrains.kotlinx:kotlinx-coroutines") #102

Closed
jmfayard opened this issue Oct 11, 2019 · 1 comment
Assignees

Comments

@jmfayard
Copy link
Member

jmfayard commented Oct 11, 2019

I have a feature currently hard-coded for kotlinx-coroutines and serializations.

It should be made configurable.

That would also increase performance once I implement #105 LouisCAD/Splitties@develop...dependencies-updates-poc


// plugin
refreshVersions {
  versionsMapping = mapOf("coroutines" to "org.getbrains.kotlinx:kotlinx-coroutines")
}


// build.gradle.kts
dependencies {
  implementation("org.jetbrains.kotlinx:kotlinx-coroutines-core:1.0.0")
  implementation("org.jetbrains.kotlinx:kotlinx-coroutines-core-common:1.0.0")
  implementation("org.jetbrains.kotlinx:kotlinx-serialization-runtime:0.13.0")
}

should generate

version.coroutines=1.0.0

One thing you have to check is whether it's actually possible to write the resolutionStrategy so that the versionsMapping we talk about works. It may be the case that we can access extension.versionsMapping only after Gradle is configured and then it's too late to use the new versions.

If not, find another solution or do something simpler like the current PluginConfig.alignVersionsForGroups

@jmfayard jmfayard changed the title groupTogether("org.getbrains.kotlinx:coroutines-.*") groupVersions("org.getbrains.kotlinx:coroutines-.*") Oct 11, 2019
@jmfayard jmfayard changed the title groupVersions("org.getbrains.kotlinx:coroutines-.*") groupStartingWith("org.getbrains.kotlinx:coroutines-") Oct 11, 2019
@jmfayard jmfayard changed the title groupStartingWith("org.getbrains.kotlinx:coroutines-") virtualGroups("org.getbrains.kotlinx:kotlinx-coroutines") Oct 11, 2019
@jmfayard jmfayard changed the title virtualGroups("org.getbrains.kotlinx:kotlinx-coroutines") PluginConfig.virtualGroups = mutableListOf("org.getbrains.kotlinx:kotlinx-coroutines") Oct 12, 2019
jmfayard pushed a commit to LouisCAD/Splitties that referenced this issue Oct 12, 2019
jmfayard pushed a commit that referenced this issue Oct 12, 2019
jmfayard pushed a commit that referenced this issue Oct 12, 2019
jmfayard pushed a commit that referenced this issue Oct 13, 2019
de.fayard.refreshVersions v0.7.0 : #65 #102 #104
@jmfayard jmfayard changed the title PluginConfig.virtualGroups = mutableListOf("org.getbrains.kotlinx:kotlinx-coroutines") alignVersionsForGroups("org.getbrains.kotlinx:kotlinx-coroutines") Oct 22, 2019
@jmfayard jmfayard self-assigned this Oct 22, 2019
@jmfayard jmfayard changed the title alignVersionsForGroups("org.getbrains.kotlinx:kotlinx-coroutines") versionsMapping = mapOf("coroutines" to "org.getbrains.kotlinx:kotlinx-coroutines") Oct 25, 2019
@LouisCAD
Copy link
Member

I think this issue is now obsolete and should be closed, do you agree @jmfayard ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants