This repository has been archived by the owner on May 14, 2020. It is now read-only.
Bug fixes to session hijacking #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in RESPONSE_HEADERS:/Set-Cookie2?/ but did match in REQUEST_COOKIES. Also there was a bug related to comparisons on collection keys that do not exist. When a request contains a cookie that has not been saved to the SESSION collection before, the intention is for tx.anomaly_score to be incremented by 5 (critical) and the rest of the checks skipped, but this does not happen. Any test on a collection key that does not exist always returns false. This means the test on SESSION:VALID "!@eq 1" returns false, when the intention is for it to return true if the session cookie has not been seen before. And the following rules in the block are run which triggers 981059,981060,981061 to return true since it is a new session collection withou ip_hash or ua_hash keys.
rcbarnett-zz
pushed a commit
that referenced
this pull request
Dec 19, 2012
Bug fixes to session hijacking
airween
pushed a commit
to airween/owasp-modsecurity-crs
that referenced
this pull request
Oct 4, 2019
syncing to upstream
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cookies did not match in RESPONSE_HEADERS:/Set-Cookie2?/ but did match in REQUEST_COOKIES. ie ASPSESSIONIDXXX.
Also there was a bug related to comparisons on collection keys that do
not exist. When a request contains a cookie that has not been saved to
the SESSION collection before, the intention is for tx.anomaly_score
to be incremented by 5 (critical) and the rest of the checks skipped,
but this does not happen. Any test on a collection key that does not
exist always returns false. This means the test on SESSION:VALID "!@eq
1" returns false, when the intention is for it to return true if the
session cookie has not been seen before. And the following rules in
the block are run which triggers 981059,981060,981061 to return true
since it is a new session collection withou ip_hash or ua_hash keys.