Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: BED-5080 - move improper int4 casts to int8 #989

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

zinic
Copy link
Contributor

@zinic zinic commented Dec 2, 2024

Description

This small change updates a few improper casts to int4 in certain SQL formatting statements.

Motivation and Context

While this won't blow up in any local test, customers that have large environments will eventually exhaust ID space for int32.

How Has This Been Tested?

Validated with schema. Types need to match from the SQL schema in schema_up.sql and in all statements addressing either the node or edge tablespace.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

@zinic zinic closed this Dec 2, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2024
@zinic zinic reopened this Dec 2, 2024
Copy link
Contributor

@superlinkx superlinkx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, pull

@zinic zinic merged commit d82941d into stage/v6.2.3 Dec 2, 2024
4 checks passed
@zinic zinic deleted the BED-5080-stage branch December 2, 2024 17:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants