Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BED-5044 - revert edge constraint map checking in API and prefer SQL upsert #961

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

zinic
Copy link
Contributor

@zinic zinic commented Nov 15, 2024

Description

Revert and change for edge creation during post-processing.

Motivation and Context

  • Related to BED-4997
  • Fixes BED-5044

The changes authored had a far greater impact on memory than expected. This ticket exists to cover reverting the change and authoring a small update to the SQL used for create to change the edge create statement into an edge upsert statement.

How Has This Been Tested?

Local test w/ folk on Zoom.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

Copy link
Contributor

@superlinkx superlinkx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate the in-depth review, all looks good

@zinic zinic merged commit 170559c into stage/v6.2.1 Nov 15, 2024
4 checks passed
@zinic zinic deleted the BED-5044 branch November 15, 2024 18:37
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants