Use initWithCoder: instead of awakeFromNib #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When configuring an SMPageControl from inside a Storyboard or XIB file, the developer might want to use User Defined Runtime Attributes to configure the instance. awakeFromNib is called after those attributes are evaluated by the loading system, effectively overwriting the attributes defined in the Storyboard or XIB file. Therefore, initWithCoder: is the more appropriate location to perform the initialization.
|
This is a solid change. I was vehemently anti-nib until fairly recently, so I'm not always aware of the nuances. Thanks for the pull requests. |
jerryhjones
added a commit
that referenced
this pull request
Mar 20, 2013
…romNib Use initWithCoder: instead of awakeFromNib
|
You're welcome. Thanks for pulling my changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When configuring an
SMPageControlfrom inside a Storyboard or XIB file, the developer might want to use User Defined Runtime Attributes to configure the instance.awakeFromNibis called after those attributes are evaluated by the nib loading system, effectively overwriting the attributes defined in the Storyboard or XIB file. Therefore,initWithCoder:is the more appropriate location to perform the initialization.