Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup simple view provider #108

Merged
merged 3 commits into from
Oct 30, 2018
Merged

cleanup simple view provider #108

merged 3 commits into from
Oct 30, 2018

Conversation

lkzhao
Copy link
Collaborator

@lkzhao lkzhao commented Oct 17, 2018

Now that class-based size source is merged. we can now simplify SimpleViewProvider.
In this PR

  • introduces a new SimpleViewSizeSource class that is responsible for taking care of view sizing.
  • makes SimpleViewProvider a subclass BasicProvider again.
  • adds some tests for BasicProvider and WaterfallLayout.
  • general cleanup after class-based size source PR.

@codecov-io
Copy link

codecov-io commented Oct 17, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@b704b3b). Click here to learn what that means.
The diff coverage is 23.25%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #108   +/-   ##
=========================================
  Coverage          ?   70.16%           
=========================================
  Files             ?       41           
  Lines             ?     1123           
  Branches          ?        0           
=========================================
  Hits              ?      788           
  Misses            ?      335           
  Partials          ?        0
Impacted Files Coverage Δ
Sources/Protocol/Provider.swift 100% <ø> (ø)
Sources/DataSource/ClosureDataSource.swift 0% <0%> (ø)
Sources/SizeSource/UIImageSizeSource.swift 0% <0%> (ø)
Sources/SizeSource/SimpleViewSizeSource.swift 0% <0%> (ø)
Sources/ViewSource/ViewSource.swift 50% <0%> (ø)
Sources/SizeSource/ClosureSizeSource.swift 100% <100%> (ø)
Sources/Provider/BasicProvider.swift 77.77% <100%> (ø)
Sources/DataSource/ArrayDataSource.swift 100% <100%> (ø)
Sources/Provider/ComposedHeaderProvider.swift 78.65% <100%> (ø)
Sources/SizeSource/SizeSource.swift 33.33% <33.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b704b3b...3703e43. Read the comment docs.

@lkzhao lkzhao requested a review from jindulys October 17, 2018 19:33
@lkzhao lkzhao merged commit 0a71118 into master Oct 30, 2018
@lkzhao lkzhao deleted the simple-view-provider-cleanup branch October 30, 2018 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants