Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class based size source #107

Merged
merged 3 commits into from
Oct 17, 2018
Merged

Class based size source #107

merged 3 commits into from
Oct 17, 2018

Conversation

lkzhao
Copy link
Collaborator

@lkzhao lkzhao commented Oct 15, 2018

#98

@lkzhao lkzhao requested a review from jindulys October 15, 2018 23:31
@lkzhao
Copy link
Collaborator Author

lkzhao commented Oct 15, 2018

This PR not only introduce class-based size source but also some convenience inits for creating BasicProvider.
We can now provide Array as DataSource, viewUpdater function as viewSource, and also provide the old sizeSource function as SizeSource.

@codecov-io
Copy link

Codecov Report

Merging #107 into master will decrease coverage by 3.81%.
The diff coverage is 17.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #107      +/-   ##
==========================================
- Coverage    56.1%   52.28%   -3.82%     
==========================================
  Files          35       37       +2     
  Lines         991     1094     +103     
==========================================
+ Hits          556      572      +16     
- Misses        435      522      +87
Impacted Files Coverage Δ
Sources/Provider/ComposedHeaderProvider.swift 0% <0%> (ø) ⬆️
.../Provider/ComposedHeaderProvider+Convenience.swift 0% <0%> (ø)
Sources/ViewSource/ClosureViewSource.swift 76.92% <100%> (ø) ⬆️
Sources/Provider/BasicProvider.swift 77.77% <100%> (ø) ⬆️
Sources/Provider/BasicProvider+Convenience.swift 20.77% <20.77%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b0571d...8942bd3. Read the comment docs.

@lkzhao lkzhao merged commit b704b3b into master Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants