-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance improvement with cell reuse #100
Conversation
Absolutely amazing improvement! 👏🏻 |
Can’t wait for this to be accepted! :) |
Codecov Report
@@ Coverage Diff @@
## master #100 +/- ##
========================================
Coverage ? 56.1%
========================================
Files ? 35
Lines ? 991
Branches ? 0
========================================
Hits ? 556
Misses ? 435
Partials ? 0
Continue to review full report at Codecov.
|
Regarding #97
@Banck gives us a brilliant idea of not removing the cells from CollectionView.
This brings major improvement in main thread cpu time.
With 10s scrolling session, reuseManager's
lifeSpan
set to 5.0s. and scrolling from top to the end every 1 second. We get the following result on an iPhone X.Notices that
CollectionView.loadCells()
cpu time changed from 558ms to 288ms.Before
After
UICollectionView
And just for comparison with UICollectionView.
UICollectionView has about the same scroll performance as CollectionKit after this patch.