Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mempool size bug in FiFoStrictBatchBuilder #897

Merged
merged 3 commits into from
Sep 19, 2023

Conversation

neysofu
Copy link
Member

@neysofu neysofu commented Sep 19, 2023

Max. mempool size calculation had an off-by-one bug.

Signed-off-by: Filippo Costa <filippo@sovlabs.io>
@neysofu neysofu enabled auto-merge September 19, 2023 13:07
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #897 (a4a4cb0) into nightly (e68cc2e) will decrease coverage by 0.2%.
Report is 1 commits behind head on nightly.
The diff coverage is 100.0%.

Files Changed Coverage Δ
rollup-interface/src/node/services/da.rs 0.0% <ø> (ø)
full-node/sov-stf-runner/src/batch_builder.rs 98.0% <100.0%> (+<0.1%) ⬆️

... and 3 files with indirect coverage changes

@neysofu neysofu added this pull request to the merge queue Sep 19, 2023
Merged via the queue into nightly with commit 0259c64 Sep 19, 2023
@neysofu neysofu deleted the filippo/batchbuilder-bug branch September 19, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants