Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated manifest test #1061

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Remove outdated manifest test #1061

merged 1 commit into from
Oct 17, 2023

Conversation

preston-evans98
Copy link
Member

Description

CI failed on nightly due to an outdated test. Because the new nextest job wasn't marked as required, the bad commit merged automatically. That issue has been fixed. This PR removes the outdated test.

@vlopes11 has already confirmed that this test is no longer needed after the changes in #1053.

Copy link
Contributor

@vlopes11 vlopes11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #1061 (ea61bc1) into nightly (606d7b8) will decrease coverage by 0.1%.
The diff coverage is n/a.

Files Coverage Δ
module-system/sov-modules-macros/src/manifest.rs 62.6% <ø> (-3.4%) ⬇️

@preston-evans98 preston-evans98 added this pull request to the merge queue Oct 17, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 17, 2023
@preston-evans98 preston-evans98 added this pull request to the merge queue Oct 17, 2023
Merged via the queue into nightly with commit 9bba488 Oct 17, 2023
@preston-evans98 preston-evans98 deleted the preston/fix-test branch October 17, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants