Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add risc0-prover to rollup-template. #1031

Merged
merged 8 commits into from
Oct 13, 2023
Merged

Add risc0-prover to rollup-template. #1031

merged 8 commits into from
Oct 13, 2023

Conversation

bkolad
Copy link
Member

@bkolad bkolad commented Oct 13, 2023 •
edited
Loading

Description

This PR introduces the following changes:

  1. Updates rollup-template tests to read GenesisConfig from .json files.
  2. It introduces the risc0 prover in rollup-template. The tests currently use the simulator for proving, but this will be modified in the next PR.

Testing

Updated relevant tetss.

Docs

No doc changes.

@codecov
Copy link

codecov bot commented Oct 13, 2023 •
edited
Loading

Codecov Report

Merging #1031 (6bdcb3f) into nightly (255a382) will increase coverage by 0.3%.
The diff coverage is n/a.

Files Coverage Δ
templates/rollup-template/src/da.rs 0.0% <ø> (ø)
templates/rollup-template/src/rollup.rs 89.5% <ø> (ø)
templates/rollup-template/src/rpc.rs 100.0% <ø> (ø)

... and 4 files with indirect coverage changes

@bkolad bkolad changed the title WIP: Add prover to rollup-template Add risc0-prover to rollup-template. Oct 13, 2023
@bkolad bkolad requested a review from neysofu October 13, 2023 11:43
@bkolad bkolad marked this pull request as ready for review October 13, 2023 11:43
@bkolad bkolad enabled auto-merge October 13, 2023 12:19
neysofu
neysofu approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@neysofu neysofu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bkolad bkolad added this pull request to the merge queue Oct 13, 2023
Merged via the queue into nightly with commit ff21c4a Oct 13, 2023
@bkolad bkolad deleted the blaze/template_rollup/prover branch October 13, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neysofu neysofu neysofu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bkolad @neysofu