Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolling is broken on macOS Safari #1458

Closed
brendon opened this issue Feb 27, 2019 · 11 comments
Closed

Scrolling is broken on macOS Safari #1458

brendon opened this issue Feb 27, 2019 · 11 comments

Comments

@brendon
Copy link

brendon commented Feb 27, 2019

Problem:

Page scrolling appears to be broken on macOS Safari. It used to work in 1.7.0 but from what I've read, the scrolling system was overhauled between then and 1.8

JSBin/JSFiddle demonstrating the problem:

http://sortablejs.github.io/Sortable/

Try to drag and drop an item with Safari and you'll notice it doesn't scroll the page. Using Firefox the page does scroll (it also works with Chrome).

@brendon
Copy link
Author

brendon commented Feb 27, 2019

Possibly related: scrollSensitivity doesn't seem to be taking effect anymore.

@owen-m1
Copy link
Member

owen-m1 commented Feb 28, 2019

@brendon If you could, please try the next-version branch and tell me if the issue occurs using that script.

@brendon
Copy link
Author

brendon commented Feb 28, 2019

Hi @owen-m1, unfortunately yes both problems still occur on that branch.

@owen-m1
Copy link
Member

owen-m1 commented Feb 28, 2019

@brendon Try master

@brendon
Copy link
Author

brendon commented Feb 28, 2019

Thanks @owen-m1, that is now working and it respects the scrollSensitivity offset on the bottom edge of the window but not the top edge anymore. I have a fixed navigation bar at the top and have set the scrollSensitivity to be greater than the height of the navigation bar. In 1.7.x it worked but not anymore with the current version. I tried increasing the scrollSensitivity amount but that didn't help.

@owen-m1
Copy link
Member

owen-m1 commented Mar 3, 2019

@brendon Please try master branch and let me know if it is working now.

@brendon
Copy link
Author

brendon commented Mar 3, 2019

Thanks @owen-m1, it all works as expected now :) Thank you so much for your help! :)

@brendon brendon closed this as completed Mar 3, 2019
@brendon
Copy link
Author

brendon commented Mar 11, 2019

Hi @owen-m1, would it be possible to have a patch version released? :)

@owen-m1
Copy link
Member

owen-m1 commented Mar 11, 2019

@brendon 1.8.4 is now released :)

@brendon
Copy link
Author

brendon commented Mar 11, 2019

Thanks @owen-m1, much appreciated :D

@anumysore5
Copy link

anumysore5 commented Aug 19, 2019

Has anyone run into this issue on 1.9.0? I am seeing this issue on an iPad on my web page only on Safari(12.4). The first list item occupies the entire viewport and trying to scroll down the page, does nothing. And all the controls on that item are also not responsive. Using preventOnFilter: false did not help either.
Could someone please suggest a work around for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants