Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpMessage] Helper Methods on Uri to make it easier to create Uri objects with query params #119

Merged
merged 2 commits into from
Nov 12, 2023

Conversation

JoshuaEstes
Copy link
Member

@JoshuaEstes JoshuaEstes commented Nov 12, 2023

Description

Adds methods

  • withQueryParams
  • withQueryParam

Also fixes URL Encoding

Checklist

  • Updated CHANGELOG files
  • Updated Documentation
  • Unit Tests Created

@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (54d699b) 70.81% compared to head (a24f9e3) 71.07%.

❗ Current head a24f9e3 differs from pull request most recent head d3ebf42. Consider uploading reports for the commit d3ebf42 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #119      +/-   ##
============================================
+ Coverage     70.81%   71.07%   +0.25%     
- Complexity     1022     1030       +8     
============================================
  Files           162      162              
  Lines          2577     2600      +23     
============================================
+ Hits           1825     1848      +23     
  Misses          752      752              
Files Coverage Δ
src/SonsOfPHP/Component/HttpMessage/Uri.php 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 12, 2023
@JoshuaEstes JoshuaEstes marked this pull request as ready for review November 12, 2023 23:40
@JoshuaEstes JoshuaEstes merged commit 814f15f into SonsOfPHP:main Nov 12, 2023
@JoshuaEstes JoshuaEstes deleted the http-message branch November 12, 2023 23:40
JoshuaEstes added a commit to JoshuaEstes/sonsofphp that referenced this pull request Nov 30, 2023
* upstream/main: (54 commits)
  [Pager] Doctrine Bridge (SonsOfPHP#175)
  fuckery (SonsOfPHP#174)
  [Money] Add Twig Bridge (SonsOfPHP#173)
  docs
  coverage fix
  typo
  SonsOfPHP#63 | Link Component (SonsOfPHP#170)
  Pager Component (SonsOfPHP#134)
  Pager Contract (SonsOfPHP#133)
  Update README.md (SonsOfPHP#124)
  [Logger] Finish up Logger Component (SonsOfPHP#123)
  Makefile
  [Logger] New Component (SonsOfPHP#120)
  bug
  [HttpMessage] Helper Methods on Uri to make it easier to create Uri objects with query params (SonsOfPHP#119)
  bug fixes
  Bug fix
  Making a few changes and breaking shit (SonsOfPHP#118)
  updating a few docs (SonsOfPHP#117)
  typo
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants