Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cache] New Component #112

Merged
merged 29 commits into from
Nov 7, 2023
Merged

[Cache] New Component #112

merged 29 commits into from
Nov 7, 2023

Conversation

JoshuaEstes
Copy link
Member

@JoshuaEstes JoshuaEstes commented Nov 6, 2023

  • php-cs-fixer
  • Documentation
  • psalm

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 6, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (e645565) 65.85% compared to head (0eb947d) 67.82%.

❗ Current head 0eb947d differs from pull request most recent head e475c7f. Consider uploading reports for the commit e475c7f to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #112      +/-   ##
============================================
+ Coverage     65.85%   67.82%   +1.96%     
- Complexity      886      975      +89     
============================================
  Files           145      152       +7     
  Lines          2308     2483     +175     
============================================
+ Hits           1520     1684     +164     
- Misses          788      799      +11     
Files Coverage Δ
.../SonsOfPHP/Component/Cache/Adapter/NullAdapter.php 100.00% <100.00%> (ø)
src/SonsOfPHP/Component/Cache/CacheItem.php 100.00% <100.00%> (ø)
src/SonsOfPHP/Component/Cache/CacheItemFactory.php 100.00% <100.00%> (ø)
...SonsOfPHP/Component/Cache/Adapter/ArrayAdapter.php 96.15% <96.15%> (ø)
src/SonsOfPHP/Component/Cache/SimpleCache.php 93.10% <93.10%> (ø)
...SonsOfPHP/Component/Cache/Adapter/ChainAdapter.php 92.68% <92.68%> (ø)
.../SonsOfPHP/Component/Cache/Adapter/ApcuAdapter.php 84.84% <84.84%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoshuaEstes JoshuaEstes marked this pull request as ready for review November 7, 2023 21:01
@JoshuaEstes JoshuaEstes merged commit 7656a53 into SonsOfPHP:main Nov 7, 2023
@JoshuaEstes JoshuaEstes deleted the cache branch November 7, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants