NET-934 Modify S1643: Add benchmarks #4593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-strecker-sonarsource
requested changes
Jan 7, 2025
4056a8e to
5d81cb3
Compare
|
|
martin-strecker-sonarsource
approved these changes
Jan 8, 2025
martin-strecker-sonarsource
requested changes
Jan 8, 2025
Comment on lines
+47
to
+48
| | StringConcatenation | .NET Framework 4.6.2 | 33,922.61 us | 302.498 us | 586450.35 KB | ||
| | StringBuilder | .NET Framework 4.6.2 | 178.14 us | 9.010 us | 244.15 KB |
There was a problem hiding this comment.
Suggested change
| | StringConcatenation | .NET Framework 4.6.2 | 33,922.61 us | 302.498 us | 586450.35 KB | |
| | StringBuilder | .NET Framework 4.6.2 | 178.14 us | 9.010 us | 244.15 KB | |
| | StringConcatenation | .NET Framework 4.8.1 | 33,922.61 us | 302.498 us | 586450.35 KB | |
| | StringBuilder | .NET Framework 4.8.1 | 178.14 us | 9.010 us | 244.15 KB |
| 12th Gen Intel Core i7-12800H, 1 CPU, 20 logical and 14 physical cores | ||
| [Host] : .NET Framework 4.8.1 (4.8.9282.0), X64 RyuJIT VectorSize=256 | ||
| .NET 9.0 : .NET 9.0.0 (9.0.24.52809), X64 RyuJIT AVX2 | ||
| .NET Framework 4.6.2 : .NET Framework 4.8.1 (4.8.9282.0), X64 RyuJIT VectorSize=256 |
There was a problem hiding this comment.
Suggested change
| .NET Framework 4.6.2 : .NET Framework 4.8.1 (4.8.9282.0), X64 RyuJIT VectorSize=256 | |
| .NET Framework 4.8.1 : .NET Framework 4.8.1 (4.8.9282.0), X64 RyuJIT VectorSize=256 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NET-934
Part of NET-929
Review
A dedicated reviewer checked the rule description successfully for: