-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JS-371 - Deprecate Node.js 18 #4913
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ericmorand-sonarsource, as mentioned during the standup, deprecating the support of a Node.js version requires also a bit of work on the Java side. In particular, we need to update the following:
Lines 40 to 44 in ac71cb1
static final Version MIN_SUPPORTED_NODE_VERSION = Version.create(18, 17, 0); | |
private static final int MIN_RECOMMENDED_NODE_VERSION = 18; | |
private static final List<String> RECOMMENDED_NODE_VERSIONS = List.of("^18.18.0", "^20.9.0", "^22.9.0"); | |
private final AnalysisWarningsWrapper analysisWarnings; |
Maybe we should document the process of deprecating a Node.js version to avoid tribal knowledge. Not sure where to write this down...
@@ -56,7 +56,7 @@ | |||
}, | |||
"homepage": "https://github.com/SonarSource/SonarJS#readme", | |||
"engines": { | |||
"node": "^18.17.0 || ^20.9.0 || >=21.1.0" | |||
"node": ">=22" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are only deprecating, not dropping support, maybe we should keep this as it was before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change establishes that the project needs Node 22 to be operated: you can't run the unit tests without at least Node 22.
.cirrus/nodejs.Dockerfile
Outdated
@@ -3,7 +3,7 @@ FROM ${CIRRUS_AWS_ACCOUNT}.dkr.ecr.eu-central-1.amazonaws.com/base:j17-latest | |||
|
|||
USER root | |||
|
|||
ARG NODE_VERSION=18 | |||
ARG NODE_VERSION=22 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's double-check with the rest of the squad whether we still want to test SonarJS against Node.js 18 on CI.
70052d3
to
2107fbf
Compare
@yassin-kammoun-sonarsource , issues should be fixed:
|
60972a5
to
12056ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left two minor suggestions about spelling, otherwise looks good to me.
Co-authored-by: Yassin Kammoun <52890329+yassin-kammoun-sonarsource@users.noreply.github.com>
Co-authored-by: Yassin Kammoun <52890329+yassin-kammoun-sonarsource@users.noreply.github.com>
Quality Gate passedIssues Measures |
JS-371