-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JS-372 Introduce caches to improve SonarLint performance #4874
Conversation
This reverts commit 136bdee.
Co-authored-by: Victor Diez <victor.diez@sonarsource.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! just a couple of minor things I'm having questions about
.cirrus.yml
Outdated
@@ -129,8 +129,6 @@ build_task: | |||
build_and_deploy_script: | |||
- source cirrus-env BUILD | |||
- node --version | |||
- npm ci | |||
- npm run check-format |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why did we remove this?
...gin/sonar-javascript-plugin/src/main/java/org/sonar/plugins/javascript/JavaScriptPlugin.java
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
As part of this improvement, we include: