Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS-157 Generate protobuf definition of ESTree #4700

Merged
merged 30 commits into from
May 27, 2024
Merged

JS-157 Generate protobuf definition of ESTree #4700

merged 30 commits into from
May 27, 2024

Conversation

ilia-kebets-sonarsource
Copy link
Contributor

No description provided.

kebetsi and others added 28 commits May 22, 2024 10:47
@kebetsi
initial work
7a5244b
@kebetsi
fix paths
890d530
@kebetsi
fix script
409d02e
@quentin-jaquier-sonarsource
Continue implementation
e3c0bbe
@kebetsi
use set
75426e7
@kebetsi
translate to proto format
0dfd0df
@kebetsi
fix oneOf indices and add JSdoc
568ee4c
@kebetsi
add prefix and output data in dedicated folder
f3b8ff6
@kebetsi
fix some formatting
ed01459
@kebetsi
compose the name of the oneOf fields with the name of the oneOf to av…
d6ebb59 
…oid collisions
@kebetsi
make index unique
8f0255c
@quentin-jaquier-sonarsource
Add top level node
4cb6f06
@quentin-jaquier-sonarsource
Flatten oneof in repeated field
4233d02
@quentin-jaquier-sonarsource
Position and SourceLocation are not nodes
caa0024
@quentin-jaquier-sonarsource
oneof names coming from type alias should not be capitalized
931e09c
@kebetsi
extract inherited properties
591a687
@kebetsi
Merge branch 'JS-157-generate-proto-file' of github.com:SonarSource/S…
1935c73 
…onarJS into JS-157-generate-proto-file
@kebetsi
update generated files
733cf3a
@kebetsi
inherited props - recursive - first try
e83485a
@quentin-jaquier-sonarsource
fix
4752b3c
@quentin-jaquier-sonarsource
Create manually TemplateElement & RegExpLiteral
2676dc4
@quentin-jaquier-sonarsource
Finish inherited fields logic
535c29a
@quentin-jaquier-sonarsource
Clean up
24ce711
@kebetsi
reverse output of extractTypeHierarchy() so we override properties co…
0280bee 
…rrectly
@kebetsi
Merge branch 'JS-157-generate-proto-file' of github.com:SonarSource/S…
5d4dc92 
…onarJS into JS-157-generate-proto-file
@kebetsi
push proto file
b755d7e
@quentin-jaquier-sonarsource
More cleanup
3050d01
@quentin-jaquier-sonarsource
Reorganize code to improve flow of logic
569cb98
@quentin-jaquier-sonarsource quentin-jaquier-sonarsource changed the title JS-157 generate proto file JS-157 Generate protobuf definition of ESTree May 24, 2024
@quentin-jaquier-sonarsource quentin-jaquier-sonarsource marked this pull request as ready for review May 24, 2024 09:43
@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@saberduck saberduck merged commit faa34b0 into master May 27, 2024
19 of 20 checks passed
@saberduck saberduck deleted the JS-157-generate-proto-file branch May 27, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quentin-jaquier-sonarsource quentin-jaquier-sonarsource quentin-jaquier-sonarsource left review comments

@saberduck saberduck saberduck approved these changes

Assignees

@ilia-kebets-sonarsource ilia-kebets-sonarsource

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ilia-kebets-sonarsource @saberduck @quentin-jaquier-sonarsource @kebetsi