Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JS-9] Rename rule S6855 to S4084 #4667

Merged
merged 2 commits into from
Apr 18, 2024
Merged

[JS-9] Rename rule S6855 to S4084 #4667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cef3131
Rename rule S6855 to S4084
vdiez Apr 18, 2024
f46b013
fix ruling results
vdiez Apr 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 ...cted/jsts/courselit/javascript-S6855.json → ...cted/jsts/courselit/javascript-S4084.json
View file
Open in desktop
File renamed without changes.
0 ...cted/jsts/courselit/typescript-S6855.json → ...cted/jsts/courselit/typescript-S4084.json
View file
Open in desktop
File renamed without changes.
0 ...expected/jsts/moose/typescript-S6855.json → ...expected/jsts/moose/typescript-S4084.json
View file
Open in desktop
File renamed without changes.
0 ...s/react-cloud-music/javascript-S6855.json → ...s/react-cloud-music/javascript-S4084.json
View file
Open in desktop
File renamed without changes.
0 packages/jsts/src/rules/S6855/cb.fixture.jsx → packages/jsts/src/rules/S4084/cb.fixture.jsx
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion packages/jsts/src/rules/S6855/cb.test.ts → packages/jsts/src/rules/S4084/cb.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,6 @@ import path from 'path';

const sonarId = path.basename(__dirname);

describe('Rule S6855', () => {
describe('Rule S4084', () => {
check(sonarId, rule, __dirname);
});
2 changes: 1 addition & 1 deletion packages/jsts/src/rules/S6855/decorator.ts → packages/jsts/src/rules/S4084/decorator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
* along with this program; if not, write to the Free Software Foundation,
* Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/
// https://sonarsource.github.io/rspec/#/rspec/S6855/javascript
// https://sonarsource.github.io/rspec/#/rspec/S4084/javascript

import { Rule } from 'eslint';
import { Node } from 'estree';
Expand Down
0 packages/jsts/src/rules/S6855/index.ts → packages/jsts/src/rules/S4084/index.ts
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions packages/jsts/src/rules/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ import { rule as S6853 } from './S6853'; // label-has-associated-control
import { rule as S1439 } from './S1439'; // label-position
import { rule as S5148 } from './S5148'; // link-with-target-blank
import { rule as S4622 } from './S4622'; // max-union-size
import { rule as S6855 } from './S6855'; // media-has-caption
import { rule as S4084 } from './S4084'; // media-has-caption
import { rule as S1994 } from './S1994'; // misplaced-loop-counter
import { rule as S1082 } from './S1082'; // mouse-events-a11y
import { rule as S134 } from './S134'; // nested-control-flow
Expand Down Expand Up @@ -414,7 +414,7 @@ rules['label-has-associated-control'] = S6853;
rules['label-position'] = S1439;
rules['link-with-target-blank'] = S5148;
rules['max-union-size'] = S4622;
rules['media-has-caption'] = S6855;
rules['media-has-caption'] = S4084;
rules['misplaced-loop-counter'] = S1994;
rules['mouse-events-a11y'] = S1082;
rules['nested-control-flow'] = S134;
Expand Down
4 changes: 3 additions & 1 deletion ...gin/javascript-checks/src/main/java/org/sonar/javascript/checks/MediaHasCaptionCheck.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,12 @@
import org.sonar.plugins.javascript.api.EslintBasedCheck;
import org.sonar.plugins.javascript.api.JavaScriptRule;
import org.sonar.plugins.javascript.api.TypeScriptRule;
import org.sonarsource.analyzer.commons.annotations.DeprecatedRuleKey;

@JavaScriptRule
@TypeScriptRule
@Rule(key = "S6855")
@DeprecatedRuleKey(ruleKey = "S6855")
@Rule(key = "S4084")
public class MediaHasCaptionCheck implements EslintBasedCheck {

@Override
Expand Down
0 ...0n/javascript/rules/javascript/S6855.html → ...0n/javascript/rules/javascript/S4084.html
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion ...0n/javascript/rules/javascript/S6855.json → ...0n/javascript/rules/javascript/S4084.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
],
"defaultSeverity": "Minor",
"ruleSpecification": "RSPEC-6855",
"sqKey": "S6855",
"sqKey": "S4084",
"scope": "All",
"quickfix": "infeasible",
"code": {
Expand Down
2 changes: 1 addition & 1 deletion ...ecks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/Sonar_way_profile.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,7 @@
"S6852",
"S6853",
"S6854",
"S6855",
"S4084",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as before, put it in order

"S6859",
"S6861",
"S6957",
Expand Down
Loading