Add cache key to css Url via

SolarFlareSoftware · Jan 12, 2022 · cc875e0 · cc875e0
1 parent 03ab4c4
commit cc875e0
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 4 deletions.
diff --git a/core/dom/document.js b/core/dom/document.js
@@ -43,6 +43,9 @@ CKEDITOR.tools.extend( CKEDITOR.dom.document.prototype, {
 	 * @param {String} cssFileUrl The CSS file URL.
 	 */
 	appendStyleSheet: function( cssFileUrl ) {
+		var cacheKey = CKEDITOR.timestamp ? '?t=' + CKEDITOR.timestamp : '';
+		cssFileUrl += cacheKey;
+
 		if ( this.$.createStyleSheet )
 			this.$.createStyleSheet( cssFileUrl );
 		else {

diff --git a/tests/core/dom/document.js b/tests/core/dom/document.js
@@ -24,10 +24,30 @@ bender.test( appendDomObjectTests(
 			var doc = new CKEDITOR.dom.document( document );
 			doc.appendStyleSheet( cssUrl );// this makes absolute URL no matter what is passed
 
-			var links = document.getElementsByTagName( 'link' );
-			var succeed = CKEDITOR.tools.array.some( links, function( link ) {
-				return link.href === cssUrl;
-			} );
+			var links = document.getElementsByTagName( 'link' ),
+				succeed = CKEDITOR.tools.array.some( links, function( link ) {
+					return link.href === cssUrl;
+				} );
+
+			CKEDITOR.timestamp = originalTimestamp;
+			assert.isTrue( succeed, 'The link element was not found' );
+		},
+
+		// (#4761)
+		'test appendStyleSheet with timestamp': function() {
+			var originalTimestamp = CKEDITOR.timestamp,
+				fakeTimestamp = 'cke4',
+				cssUrl = CKEDITOR.basePath + 'tests/_assets/sample.css',
+				expectedCssUrl = cssUrl + '?t=' + fakeTimestamp;
+
+			CKEDITOR.timestamp = fakeTimestamp;
+			var doc = new CKEDITOR.dom.document( document );
+			doc.appendStyleSheet( cssUrl );// this makes absolute URL no matter what is passed
+
+			var links = document.getElementsByTagName( 'link' ),
+				succeed = CKEDITOR.tools.array.some( links, function( link ) {
+					return link.href === expectedCssUrl;
+				} );
 
 			CKEDITOR.timestamp = originalTimestamp;
 			assert.isTrue( succeed, 'The link element was not found' );