Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update nest to v9 #42

Merged
merged 4 commits into from
Aug 12, 2022
Merged

chore(deps): update nest to v9 #42

merged 4 commits into from
Aug 12, 2022

Conversation

serembon
Copy link
Contributor

@serembon serembon commented Jul 17, 2022

Updated Nestjs deps to v9

Closes #43

package.json Outdated
@@ -1,6 +1,6 @@
{
"name": "@adminjs/nestjs",
"version": "5.0.0",
"version": "5.0.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't update the version manually, we use semantic-release library to create versions automatically, more info here: https://github.com/SoftwareBrothers/adminjs/blob/master/CONTRIBUTING.md#development

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, too

package.json Outdated
@@ -18,16 +18,16 @@
}
},
"peerDependencies": {
"@nestjs/common": "^8.2.6",
"@nestjs/core": "^8.2.6",
"@nestjs/common": "^9.0.5",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there are no breaking changes required in the code, can we change the version to:

    "@nestjs/common": ">=9.0.5",
    "@nestjs/core": ">=9.0.5",

This should prevent us from having to create more bump releases.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@dziraf dziraf merged commit 81d127c into SoftwareBrothers:master Aug 12, 2022
github-actions bot pushed a commit that referenced this pull request Aug 12, 2022
@github-actions
Copy link

🎉 This PR is included in version 5.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore(deps): update nestjs to v9
2 participants