Add defineGetter to registry lib/objects

SocketDev · Jan 17, 2025 · deac9ee · deac9ee
1 parent 30ca7df
commit deac9ee
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 6 deletions.
diff --git a/registry/lib/constants.d.ts b/registry/lib/constants.d.ts
@@ -32,6 +32,11 @@ interface Internals {
     getter: () => T,
     stats?: LazyGetterStats
   ) => () => T
+  readonly defineGetter: <T>(
+    object: object,
+    propKey: PropertyKey,
+    getter: () => T
+  ) => object
   readonly defineLazyGetter: <T>(
     object: object,
     propKey: PropertyKey,

diff --git a/registry/lib/constants.js b/registry/lib/constants.js
@@ -131,6 +131,7 @@ const matcherCache = new Map()
 const internalsMixin = {
   createConstantsObject,
   createLazyGetter,
+  defineGetter,
   defineLazyGetter,
   defineLazyGetters,
   getGlobMatcher,
@@ -195,15 +196,15 @@ function createLazyGetter(name, getter, stats) {
   return lazyGetter
 }
 
-function defineLazyGetter(object, propKey, getter, stats) {
-  __defineGetter__.call(
-    object,
-    propKey,
-    createLazyGetter(propKey, getter, stats)
-  )
+function defineGetter(object, propKey, getter) {
+  __defineGetter__.call(object, propKey, getter)
   return object
 }
 
+function defineLazyGetter(object, propKey, getter, stats) {
+  return defineGetter(object, propKey, createLazyGetter(propKey, getter, stats))
+}
+
 function defineLazyGetters(object, getterDefObj, stats) {
   if (getterDefObj !== null && typeof getterDefObj === 'object') {
     const keys = Reflect.ownKeys(getterDefObj)

diff --git a/registry/lib/objects.d.ts b/registry/lib/objects.d.ts
@@ -22,6 +22,7 @@ declare function toSortedObjectFromEntries<T>(
 }
 declare const objectsModule: {
   createLazyGetter: Internals['createLazyGetter']
+  defineGetter: Internals['defineGetter']
   defineLazyGetter: Internals['defineLazyGetter']
   defineLazyGetters: Internals['defineLazyGetters']
   getOwnPropertyValues: typeof getOwnPropertyValues

diff --git a/registry/lib/objects.js b/registry/lib/objects.js
@@ -8,6 +8,7 @@ const {
   kInternalsSymbol,
   [kInternalsSymbol]: {
     createLazyGetter,
+    defineGetter,
     defineLazyGetter,
     defineLazyGetters,
     objectEntries,
@@ -126,6 +127,7 @@ function toSortedObjectFromEntries(entries) {
 
 module.exports = {
   createLazyGetter,
+  defineGetter,
   defineLazyGetter,
   defineLazyGetters,
   getOwnPropertyValues,