This repository has been archived by the owner on Oct 22, 2024. It is now read-only.
Fix Smoketests CI #136
Merged
Fix Smoketests CI #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alistair-singh
approved these changes
Apr 8, 2024
vgeddes
approved these changes
Apr 8, 2024
|
@alistair-singh I do think its good to run on snowbridge if it changes. It is infrequently and then we'll know what change (or at least what PR) broke it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the paths are preventing it from running, since the checkout folders are snowbridge/polkadot-sdk. I don't think the path qualifiers are needed, it can always run when something changes on
snowbridge.