Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Snowflake Resource for Streams #286

Merged
merged 2 commits into from
Oct 30, 2020

Conversation

axis-deputy
Copy link
Contributor

@axis-deputy axis-deputy commented Oct 26, 2020

NOTE: Was approved from Master PR 280. Re-created it now from Main branch

Summary of changes

  1. Created a resource to support the creation of streams in Snowflake
  2. Note: Resource for Stream Grants is not part of this PR.

Sample Syntax:

resource "snowflake_stream" "test_stream" {
	database = "your_database_name"
	schema   = "your_schema_name"
	name     = "your_new_stream"
	comment  = "Terraform acceptance test"
	on_table = "target_db.target_schema.target_table"
	append_only = true
	
}

Test Plan

  1. Internal and Unit test was implemented and done.
  2. Acceptance test was done using our own Snowflake account. make test-acceptance was executed from the terminal
  3. Sanity check was done by creating a local build of the provider and installing the plugin in our terraform project to test the creation of the streams

References

Linked Issue

- recreating fork
-moving from master to main
@axis-deputy axis-deputy requested a review from a team as a code owner October 26, 2020 02:34
@axis-deputy axis-deputy requested review from alldoami and removed request for a team October 26, 2020 02:34
Copy link
Contributor

@alldoami alldoami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! sorry about that

@alldoami alldoami merged commit 8ae815c into Snowflake-Labs:main Oct 30, 2020
gjv9491 pushed a commit to gjv9491/terraform-provider-snowflake that referenced this pull request Mar 19, 2021
anton-chekanov pushed a commit to anton-chekanov/terraform-provider-snowflake that referenced this pull request Jan 25, 2022
daniepett pushed a commit to daniepett/terraform-provider-snowflake that referenced this pull request Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants