Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] credit quota as float on read, int on write #274

Merged
merged 1 commit into from
Oct 13, 2020
Merged

[fix] credit quota as float on read, int on write #274

merged 1 commit into from
Oct 13, 2020

Conversation

andybeeswax
Copy link
Contributor

@andybeeswax andybeeswax commented Oct 13, 2020 •
edited
Loading

Snowflake only accepts credit_quota as an int. However, the show resource monitors command returns it as a float. This PR converts the float read from Snowflake into an int.

Test Plan

  • acceptance tests

References

Fixes #145 and #109

@andybeeswax andybeeswax requested a review from a team as a code owner October 13, 2020 00:50
@andybeeswax andybeeswax requested review from alldoami and removed request for a team October 13, 2020 00:50
@ryanking ryanking changed the title Change credit quota to float on read, int on write [fix] credit quota as float on read, int on write Oct 13, 2020
@ryanking ryanking merged commit 26a0a0b into Snowflake-Labs:main Oct 13, 2020
@andybeeswax andybeeswax deleted the credit_quota_int branch October 13, 2020 17:37
gjv9491 pushed a commit to gjv9491/terraform-provider-snowflake that referenced this pull request Mar 19, 2021
@andybeeswax
change credit quota to float on read, int on write (Snowflake-Labs#274)
e9f0cb6 
Snowflake only accepts credit_quota as an int.  However, the `show resource monitors` command returns it as a float.  This PR converts the float read from Snowflake into an int.  


## Test Plan
<!-- detail ways in which this PR has been tested or needs to be tested -->
* [x] acceptance tests
<!-- add more below if you think they are relevant -->

## References
Fixes Snowflake-Labs#145 and Snowflake-Labs#109
anton-chekanov pushed a commit to anton-chekanov/terraform-provider-snowflake that referenced this pull request Jan 25, 2022
@andybeeswax @anton-chekanov
change credit quota to float on read, int on write (Snowflake-Labs#274)
81c0da4 
Snowflake only accepts credit_quota as an int.  However, the `show resource monitors` command returns it as a float.  This PR converts the float read from Snowflake into an int.  


## Test Plan
<!-- detail ways in which this PR has been tested or needs to be tested -->
* [x] acceptance tests
<!-- add more below if you think they are relevant -->

## References
Fixes Snowflake-Labs#145 and Snowflake-Labs#109
daniepett pushed a commit to daniepett/terraform-provider-snowflake that referenced this pull request Feb 9, 2022
@andybeeswax
change credit quota to float on read, int on write (Snowflake-Labs#274)
ecefa8a 
Snowflake only accepts credit_quota as an int.  However, the `show resource monitors` command returns it as a float.  This PR converts the float read from Snowflake into an int.  


## Test Plan
<!-- detail ways in which this PR has been tested or needs to be tested -->
* [x] acceptance tests
<!-- add more below if you think they are relevant -->

## References
Fixes Snowflake-Labs#145 and Snowflake-Labs#109
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanking ryanking ryanking approved these changes

@alldoami alldoami Awaiting requested review from alldoami

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resource Monitor CREDIT_QUOTA type
2 participants
@andybeeswax @ryanking