fix: diffs always occurring when multiple columns exist #2686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YAhiru
commented
Apr 8, 2024
| resource.TestCheckResourceAttr("snowflake_masking_policy.test", "schema", acc.TestSchemaName), | ||
| resource.TestCheckResourceAttr("snowflake_masking_policy.test", "masking_expression", "case when current_role() in ('ANALYST') then val else sha2(val, 512) end"), | ||
| resource.TestCheckResourceAttr("snowflake_masking_policy.test", "return_data_type", "VARCHAR"), | ||
| resource.TestCheckResourceAttr("snowflake_masking_policy.test", "signature.#", "1"), |
There was a problem hiding this comment.
Previously, signature.# was 2
|
Hey @YAhiru. Thanks for the pull request! We will review it tomorrow (cc: @sfc-gh-jcieslak). |
|
/ok-to-test sha=4d8a779af7c3f8ca59c3b4dc205f0724fe26bf6a |
|
Integration tests failure for 4d8a779af7c3f8ca59c3b4dc205f0724fe26bf6a |
1 similar comment
|
Integration tests failure for 4d8a779af7c3f8ca59c3b4dc205f0724fe26bf6a |
sfc-gh-asawicki
approved these changes
Apr 10, 2024
sfc-gh-jcieslak
approved these changes
Apr 10, 2024
|
Merged. Thanks for the contribution @YAhiru. |
sfc-gh-jcieslak
pushed a commit
that referenced
this pull request
Apr 18, 2024
🤖 I have created a release *beep* *boop* --- ## [0.89.0](v0.88.0...v0.89.0) (2024-04-18) ### 🎉 **What's new:** * Update target objects for privilege-granting resources ([#2688](#2688)) ([74e2b6b](74e2b6b)) ### 🔧 **Misc** * Handle generic check destroy in acceptance tests ([#2716](#2716)) ([63a5324](63a5324)) * Initialize the SDK client in fewer places ([#2710](#2710)) ([382bfc1](382bfc1)) ### 🐛 **Bug fixes:** * Adds case statement for ObjectTypeUser in ShowObjectParameter. ([#2675](#2675)) ([23a3341](23a3341)) * diffs always occurring when multiple columns exist ([#2686](#2686)) ([3275ad4](3275ad4)) * Fix issues [#2679](#2679) [#2721](#2721) ([#2723](#2723)) ([b0c9dd4](b0c9dd4)) * Fix several small issues ([#2697](#2697)) ([e3f6a15](e3f6a15)) * granting ownership on database roles ([#2703](#2703)) ([88944e7](88944e7)) * network policy update ([#2647](#2647)) ([8126b28](8126b28)) * Rename grants_redesign_desgin_decisions.md to grants_redesign_design_… ([#2691](#2691)) ([5000b2b](5000b2b)) * renames in update operations ([#2702](#2702)) ([793c879](793c879)) * showbyid method tests ([#2648](#2648)) ([ff5e617](ff5e617)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReadMaskingPolicy function increased signature by the number of columns when there were multiple columns in the Masking Policy.
Therefore, a masking policy with multiple columns was always in a state where differences occurred.
Test Plan
References