[fix] Add shares to grant ResourceData #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you write tests for this? Thanks for the great work! 😄 |
…m/andybeeswax/terraform-provider-snowflake into add_shares_to_grant_resource_data
|
@alldoami You're welcome! Added some tests. |
|
Passed |
alldoami
approved these changes
Oct 9, 2020
…provider-snowflake into add_shares_to_grant_resource_data
…m/andybeeswax/terraform-provider-snowflake into add_shares_to_grant_resource_data
…ovider-snowflake into add_shares_to_grant_resource_data
gjv9491
pushed a commit
to gjv9491/terraform-provider-snowflake
that referenced
this pull request
Mar 19, 2021
anton-chekanov
pushed a commit
to anton-chekanov/terraform-provider-snowflake
that referenced
this pull request
Jan 25, 2022
daniepett
pushed a commit
to daniepett/terraform-provider-snowflake
that referenced
this pull request
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grants don't recognize when privileges are already granted to a share. So the grant resources are recreated on every apply. This should resolve that. The shares weren't being added to the ResourceData.
This should fix #226.
It may fix #248 as well.
Test Plan