README development improvements #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edulop91
reviewed
Jul 31, 2020
edulop91
reviewed
Jul 31, 2020
README.md
Outdated
Comment on lines
39
to
42
| export GOPATH=$HOME/../go_projects # edit with your go_projects dir | ||
| export GOROOT=/usr/local/opt/go/libexec | ||
| export PATH=$PATH:$GOPATH/bin | ||
| export PATH=$PATH:$GOROOT/bin |
There was a problem hiding this comment.
Are these still necessary with Go 1.13+?
There was a problem hiding this comment.
I literally just started with Go so you'll know more than me! I can try on a fresh environment without
There was a problem hiding this comment.
Answer is it depends how you install. If you install Go with the package installer from here then the required directories are added to PATH. If you install with brew, you need to do it yourself.
There was a problem hiding this comment.
You're right, GOROOT no longer required. I've tidied it up and also added a missing step for goimport.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A step-by-step guide. Hopefully this will improve the frequency of contributions