Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apostrophe character in comment breaks schema resource creation #127

Closed
pwnage101 opened this issue Jan 10, 2020 · 1 comment · Fixed by #231
Closed

Apostrophe character in comment breaks schema resource creation #127

pwnage101 opened this issue Jan 10, 2020 · 1 comment · Fixed by #231
Assignees
@ryanking
Labels
bug Used to mark issues with provider's incorrect behavior

Comments

@pwnage101
Copy link
Contributor

If the comment parameter on a snowflake_schema resource contains an apostrophe, that's probably not escaped correctly during resource creation because it causes snowflake syntax errors and fails the creation.

I haven't tested other resources, but I suspect it might be also problematic elsewhere.

I'd paste the error I got, but it's a syntax error on the next token following the apostrophe, which isn't going to be consistent for this bug.
@ryanking
Copy link
Contributor

@pwnage101 I am not surprised by this, we have not been diligent about escaping.

@ryanking ryanking added the bug Used to mark issues with provider's incorrect behavior label May 12, 2020
@ryanking ryanking self-assigned this Jul 29, 2020
@ryanking ryanking mentioned this issue Jul 29, 2020
Merged
1 task
czimergebot pushed a commit that referenced this issue Aug 3, 2020
@ryanking
[fix] escape some strings in query builders (#231)
7edd15b 
Escape comments and other string fields that are not currently escaped in our query builders.

## Test Plan
<!-- detail ways in which this PR has been tested or needs to be tested -->
* [ ] acceptance tests

## References
* Fixes #127
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryanking ryanking

Labels
bug Used to mark issues with provider's incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[fix] escape some strings in query builders Snowflake-Labs/terraform-provider-snowflake
2 participants
@ryanking @pwnage101