Schema update - Indexes and NOT NULL constraints #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add NOT NULL constraints on the DB level to columns that are required information for data integrity. Issue GH-154
Layers have a relationship to DOI through their site association and don't need a reference here. A site is also a required association since it will store the geom column for any layer data.
Also fixes the setup step to copy the credentials files first before running the check.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-0.6.x #181 +/- ##
=================================================
+ Coverage 70.19% 75.80% +5.61%
=================================================
Files 12 21 +9
Lines 416 649 +233
=================================================
+ Hits 292 492 +200
- Misses 124 157 +33 ☔ View full report in Codecov by Sentry. |
Add an index to frequently queried columns and foreign key relationships for faster lookup. GH-154
Use the `Metadata` object to set the schema name on all tables via the attribute. This prepares defining index on a per-table basis via the `__table_args__`
Require unique combinations for point/date and site/date combinations. Closes GH-154
micah-prime
reviewed
Feb 11, 2025
micah-prime
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed last week and in GH-154
Some code got reformatted by my IDE, which I kept.