Refactor credentials file handling - Prepare use in snowex_db #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor the credential file lookup and look for the required file under the project root for production or test values. This introduces two separate sections under the central JSON file, containing both environment values. Co-authored-by: aaarendt <arendta@uw.edu>
Co-authored-by: aaarendt <arendta@uw.edu>
Started to fail with GH actions, but not locally. Hoping that this is a single over double-quote issue with f-strings and dictionary access.
micah-prime
approved these changes
Jan 29, 2025
|
Looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the credential file lookup and look for the required file
under the project root for production or test values. This introduces
two separate sections under the central JSON file, containing both
environment values.
Triggering the 'TESTS' namespace in pytest runs is done via OS environment variable.