PR remarks

SnellerInc · May 11, 2023 · 5838201 · 5838201
1 parent 709a5df
commit 5838201
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/pkg/plugin/api.go b/pkg/plugin/api.go
@@ -106,7 +106,7 @@ func (d *Datasource) getColumns(ctx context.Context, database, table string) ([]
 		return cached.([]string), 0, nil
 	}
 
-	resp, err := d.executeQuery(ctx, database, fmt.Sprintf(`SELECT SNELLER_DATASHAPE(*) FROM (SELECT * FROM %s LIMIT 1000)`, table))
+	resp, err := d.executeQuery(ctx, database, fmt.Sprintf(`SELECT SNELLER_DATASHAPE(*) FROM (SELECT * FROM %q LIMIT 1000)`, table))
 	if err != nil {
 		if resp != nil {
 			return nil, resp.StatusCode, err

diff --git a/src/components/QueryEditor.tsx b/src/components/QueryEditor.tsx
@@ -41,7 +41,7 @@ export function QueryEditor({ datasource, query, onChange, onRunQuery }: Props)
             return []
         }
         try {
-            const response = await datasource.getResource('tables/' + database) as string[];
+            const response = await datasource.getResource('tables/' + encodeURIComponent(database)) as string[];
             return (response.map((x) => ({
                 name: x,
             })));
@@ -55,7 +55,9 @@ export function QueryEditor({ datasource, query, onChange, onRunQuery }: Props)
             return []
         }
         try {
-            const response = await datasource.getResource('columns/' + database + '/' + table.table) as string[];
+            const response = await datasource.getResource(
+                'columns/' + encodeURIComponent(database) + '/' + encodeURIComponent(table.table)
+            ) as string[];
             return (response.map((x) => ({
                 name: x,
             })));