[WIP] Upgrade to wayland-rs 0.20 #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30f1b5a to
e44b0e5
Compare
|
Okay, with this the porting should be complete. r? @Drakulix 😄 |
|
With this last commit, we can even work around the rustc bug, and retrieve all functionality 🎉 |
Drakulix
approved these changes
Apr 23, 2018
examples/udev.rs
Outdated
| @@ -435,14 +421,15 @@ fn main() { | |||
| libinput_event_source.remove(); | |||
|
|
|||
| // destroy the udev backend freeing the drm devices | |||
| udev_event_source.remove().close(&mut event_loop) | |||
| udev_backend = *(downcast_impl(udev_event_source.remove()).unwrap_or_else(|_| unreachable!())); | |||
There was a problem hiding this comment.
Maybe put a small explanation here, what this does?
| @@ -48,11 +49,13 @@ pub struct UdevBackend< | |||
| S: Session + 'static, | |||
| T: UdevHandler<H> + 'static, | |||
| > { | |||
| devices: Rc<RefCell<HashMap<dev_t, FdEventSource<(DrmDevice<SessionFdDrmDevice>, H)>>>>, | |||
| _handler: ::std::marker::PhantomData<H>, | |||
There was a problem hiding this comment.
Is there a good reason to keep this type parameter? Otherwise lets just drop it, if it is not required anymore.
There was a problem hiding this comment.
The reason to keep it is because it appears in the T: UdevHandler<H> constraint.
It may be possible to remove it, but I expect it'd require a significant refactor.
There was a problem hiding this comment.
Well than lets skip that for now.
src/wayland/shell/legacy/mod.rs
Outdated
| //! This module provides automatic handling of shell surfaces objects, by being registered | ||
| //! as a global handler for `wl_shell`. This protocol is deprecated in favor of `xdg_shell`, | ||
| //! thus this module is provided as a compatibility layer with older clients. As a consequence, | ||
| //! you can as a compositor-writer decide to only support its fonctionnality in a best-effort |
|
Looks good for merge! |
|
Alright then, let's go ! |
Drakulix
added a commit
that referenced
this pull request
Dec 7, 2023
Update primary scanout output when not visible on previous output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an on-going work to upgrade smithay to the new incoming wayland-rs 0.20 API. Doing this work allows me to find out what is bad/missing from wayland-rs API, notably.
TODO: