Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Neat URL] Probable bugs when urlDecode whole URL #75

Closed
gwarser opened this issue Oct 19, 2017 · 0 comments
Closed

[Neat URL] Probable bugs when urlDecode whole URL #75

gwarser opened this issue Oct 19, 2017 · 0 comments
Labels

Comments

@gwarser
Copy link
Contributor

gwarser commented Oct 19, 2017

Please stop urlDecoding URL at a whole on the beginning of cleaning. This looses information! L460

For example:

  • create rule foo@example.com
  • go to example.com?foo%3Dbar=baz
  • browser should send: foo=bar == baz
  • extension sees example.com?foo=bar=baz
  • extension removes foo == bar=baz

Another:

  • go to example.com?foo=bar&ab%3Dcd=ef
  • after cleaning, browser should send ab=cd == ef
  • actually ab == cd=ef is sent

Related #73

If this is really needed, do this after splitting by ?, & and =.
If you want to support url's like this: example.com?url=example2.com%3Futm%3Dsomething you should probably use recursion ;) URLs like this will be cleaned after redirection to example2.com.

Smile4ever added a commit that referenced this issue Dec 1, 2017
* Performance improvements
* Several encoding bugs fixed #73 #75 #93
* Re-initialise listener, hopefully fixes #92
* Fix "Show counter" setting (introduced in 3.2.0) doesn't do anything #91
* Workaround for gws_rd@google.* on google.com #76
* Implement hash parameters using #? #83
* Cleanups
* Fix translation string mapped to wrong i18n id
* Move most functions related to the toolbar button to a separate file
@gwarser gwarser closed this as completed Dec 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants