Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TableMaintainer 2.2.4 backward compat. #993

Closed
wants to merge 1 commit into from

Conversation

afoucret
Copy link
Contributor

No description provided.

@afoucret
Copy link
Contributor Author

Hi @djenvert nicobatty,

Could you please confirm this PR restore the 2.2.4 backward compat.

Thx for reporting

@ccasciotti
Copy link

Hi @afoucret,
I have the same issue, I've implemented this PR in my enviroment and I can confirm that it works with:

Magento Commerce 2.2.4
Smile ElasticSuite 2.5.13

I hope this help.

@pczerkas
Copy link
Contributor

pczerkas commented Jul 2, 2018

Hello,
unfortunaltelly, on 2.2.4
$this->objectManager->get('Magento\Catalog\Model\Indexer\Category\Product\TableMaintainer')
throws ReflectionException
Class Magento\Catalog\Model\Indexer\Category\Product\TableMaintainer does not exist
on indexer:reindex

@moejoee91
Copy link

Still not fixed in 2.2.4 unfortunately

@ccasciotti
Copy link

Sorry for my previous comment, it was a false positive, isn't fixed on 2.2.4.
I think that it can be fixed by wrapping objectManager with a try-catch block.

@romainruaud
Copy link
Collaborator

Closed in favor of #1005

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants