Changed ClientConfiguration instance used in ConfigOptionsList #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ensure that ScopeConfigInteface isn't accessed prior to Magento initialization The custom options array previously passed to Client\ClientConfiguration was to allow for the setup:install parameters supplied via CLI to be passed to the client in order to validate the connection settings before proceeding with Magento installation. This has been removed, as it doesn't look like there is currently any use cases that require it. It has been extracted into a separate ClientConfigurationInterface implementation so that ConfigOptionsList can construct an instance without touching ScopeConfigInterface, as this caused the following: - Notice: Undefined index: websites in module-config/App/Config/Type/System.php on line 248 - Empty config to be saved to cache prior to Magento install (unknown what this causes currently) Fixes #738
|
Closed in favor of #769 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed ClientConfiguration instance used in ConfigOptionsList to ensure that ScopeConfigInteface isn't accessed prior to Magento initialization.
The custom options array previously passed to Client\ClientConfiguration was to allow for the setup:install parameters supplied via CLI to be passed to the client in order to validate the connection settings before proceeding with Magento installation.
This has been removed, as it doesn't look like there is currently any use cases that require it. It has been extracted into a separate ClientConfigurationInterface implementation so that ConfigOptionsList can construct an instance without touching ScopeConfigInterface, as this caused the following:
Fixes #738