Check if adminSoertIndex key exists #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Leone, I think it would be nice to release this patch in the 2.5.1 release since the next major release (2.6.0) is not coming before 2 months. Could you rebase this PR from branch 2.5.x, please ? |
e110233 to
28b8a48
Compare
|
Hi @afoucret, I rebased pull request from branch 2.5.x. |
|
Hi @Leone, I have merged it in the branch 2.5.x and it will be part of the next maintenance release (2.5.x). Thx for contributing, |
Koc
reviewed
Feb 13, 2018
| return 0; | ||
| } | ||
|
|
||
| return $item1['adminSortIndex'] <= $item2['adminSortIndex'] ? -1 : 1; |
There was a problem hiding this comment.
Looks like this can be replaced with single line:
return $item1['adminSortIndex'] ?? 0 <=> $item2['adminSortIndex'] ?? 0;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #729
This one fix the missing adminSortIndex issue.
If you change the option label in the filter attribute in the admin panel, the script doesn't see this option, doesn't set key adminSortIndex and throws an error in usort() function.
This issue exists in all versions.
Regards,
Grzegorz