Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute correctly attributes option values from products, when used i… #495

Merged

Conversation

romainruaud
Copy link
Collaborator

…n autocomplete.

For now, if you inject an option based attribute (let's say "manufacturer") and try to display the data in the html template, you will see the option_id.

This is due to the fact we just use $product->getData($attributeCode) which is not rendering properly the attribute value.

$product->getAttributeText($attributeCode) should be used with option based attributes.

regards

@afoucret afoucret merged commit 087043f into Smile-SA:2.3.x Aug 10, 2017
@romainruaud romainruaud deleted the fix_autocomplete-select-attributes branch September 8, 2017 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants