Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1591 #1581 Explicit collection page size #1604

Merged
merged 1 commit into from
Nov 4, 2019
Merged

Fixes #1591 #1581 Explicit collection page size #1604

merged 1 commit into from
Nov 4, 2019

Conversation

rbayet
Copy link
Collaborator

@rbayet rbayet commented Oct 30, 2019 •
edited
Loading

when only fetching aggregations.
Keeps the "Show all" working by distinguishing between NO page size set ("Show all") and a page size of 0.
Also covers someone setting a page size of null for the fun.

@rbayet rbayet self-assigned this Oct 30, 2019
@rbayet
Copy link
Collaborator Author

rbayet commented Oct 30, 2019 •
edited
Loading

Alternative to PR #1603 which builds on merged PR #1598.
To test on a medium to huge size catalog.
To test also through the Rest API if applicable (see with @romainruaud ?).

@rbayet rbayet mentioned this pull request Oct 30, 2019
Closed
@rbayet rbayet force-pushed the fix_1581_1591_better_show_all_support branch from edbb912 to f20924a Compare October 31, 2019 13:08
@rbayet rbayet requested a review from romainruaud October 31, 2019 14:47
@rbayet rbayet assigned romainruaud and unassigned rbayet Oct 31, 2019
@rbayet
Fixes Smile-SA#1591 Smile-SA#1581 Explicit collection page size
78c5bd0 
when only fetching aggregations.
Keeps the "Show all" working by distinguishing between NO page size set ("Show all") and a page size of 0.
Also covers someone setting a page size of null for the fun.
@rbayet rbayet force-pushed the fix_1581_1591_better_show_all_support branch from f20924a to 78c5bd0 Compare October 31, 2019 15:03
@romainruaud
Copy link
Collaborator

Seems way cleaner like this !

@romainruaud romainruaud merged commit 08ac95b into Smile-SA:2.8.x Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romainruaud romainruaud Awaiting requested review from romainruaud

Assignees

@romainruaud romainruaud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rbayet @romainruaud