Update InventoryData.php to work with both return types #1600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove return type since it can be either Deprecation or InventoryDataInterface..
Update InventoryData.php
|
Self-note: if validated, squash and merge. |
|
@romainruaud Any philosophical requirement to also change the PHPdoc return type ? |
|
I did not see anything non-working on this piece of code. Removing the return type should not break anything either. But why do you want to remove it exactly @southerncomputer ? what's the use case ? |
|
We were having extremely long reindex times with the buggy MSI implementation in ee 2.3.3 - so we removed that library and only have cataloginventory which results in Deprecated::Class which is not compatible with inventoryinterface return type.. Throws an error with php 7.3.11 :( |
|
Okay then it could be due to PHP 7.3 :) We'll try to merge this one asap |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update InventoryData.php to work with both return types: deprecated and inventorydatainterface...