Fixes #1503 fix sorting in Visual Swatches attribute #1550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbayet
requested changes
Oct 14, 2019
src/module-elasticsuite-swatches/Block/Navigation/Renderer/Swatches/RenderLayered.php
Show resolved
Hide resolved
|
|
||
| $attributeOptions = []; | ||
| $attributeOptionsSort = []; | ||
|
|
There was a problem hiding this comment.
- Add a comment explaining you are collecting the options labels in the expected order (as defined in the attribute options in admin).
src/module-elasticsuite-swatches/Block/Navigation/Renderer/Swatches/RenderLayered.php
Show resolved
Hide resolved
src/module-elasticsuite-swatches/Block/Navigation/Renderer/Swatches/RenderLayered.php
Show resolved
Hide resolved
src/module-elasticsuite-swatches/Block/Navigation/Renderer/Swatches/RenderLayered.php
Outdated
Show resolved
Hide resolved
|
Requested some purely cosmetics/documentation changes. |
rbayet
requested changes
Oct 15, 2019
src/module-elasticsuite-swatches/Block/Navigation/Renderer/Swatches/RenderLayered.php
Outdated
Show resolved
Hide resolved
src/module-elasticsuite-swatches/Block/Navigation/Renderer/Swatches/RenderLayered.php
Outdated
Show resolved
Hide resolved
rbayet
approved these changes
Oct 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.