Fixes #1488 Fixed indexing children_attributes for configurable produ… #1545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romainruaud
previously requested changes
Sep 20, 2019
src/module-elasticsuite-catalog/Model/Product/Indexer/Fulltext/Datasource/AttributeData.php
Show resolved
Hide resolved
|
Before you take it @rbayet : for me there is something missing/broken : the "name" attribute get merged with this PR, but it was not the case before. It's better to have "name" unmerged especially for the sort by name. |
I concur. |
rbayet
requested changes
Oct 15, 2019
| $parentAttributeCodes | ||
| ); | ||
| $childrenAttributes = array_merge($addedChildrenAttributes, $parentData['children_attributes']); | ||
| $childrenAttributes = array_merge($childrenAttributes, $parentData['children_attributes']); |
rbayet
requested changes
Oct 16, 2019
src/module-elasticsuite-catalog/Model/Product/Indexer/Fulltext/Datasource/AttributeData.php
Outdated
Show resolved
Hide resolved
…ct while creating
rbayet
approved these changes
Oct 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ct while creating