Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature allow resetting sort order 2.6.x #1331

Merged

Conversation

rbayet
Copy link
Collaborator

@rbayet rbayet commented Feb 25, 2019

Revamp of PR #1328 to address the phpmd issue.
(See possible origin/fix : phpmd/phpmd#409 and phpmd/phpmd#495)

@rbayet rbayet force-pushed the feature-allow-resetting-sort-order-2.6.x branch 2 times, most recently from ae48110 to 0b66bec Compare February 25, 2019 10:35
@rbayet rbayet force-pushed the feature-allow-resetting-sort-order-2.6.x branch from 0b66bec to 563077c Compare February 25, 2019 10:49
@rbayet
Copy link
Collaborator Author

rbayet commented Feb 25, 2019

Correct warning suppresson was PHPMD.TooManyPublicMethods and it had to be located at the end of the class' PHPDoc block.

@rbayet rbayet merged commit 7083c0f into Smile-SA:2.6.x Feb 25, 2019
@rbayet rbayet deleted the feature-allow-resetting-sort-order-2.6.x branch March 1, 2019 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant