Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aggregations: support for pipeline aggs and filter #1296

Merged
merged 3 commits into from
Feb 12, 2019
Merged

Aggregations: support for pipeline aggs and filter #1296

merged 3 commits into from
Feb 12, 2019

Conversation

rbayet
Copy link
Collaborator

@rbayet rbayet commented Feb 6, 2019

Both can be defined in a container.
Only bucket selector pipeline aggregation for now.

@rbayet rbayet force-pushed the feat-aggs-pipelines-and-filters branch 4 times, most recently from 09e4670 to e6320fb Compare February 7, 2019 16:29
@rbayet
Aggregations: support for pipeline aggs and filter
446d811 
Both can be defined in a container.
Only bucket selector pipeline aggregation for now.
@rbayet rbayet force-pushed the feat-aggs-pipelines-and-filters branch from e6320fb to 446d811 Compare February 7, 2019 19:30
@rbayet
Copy link
Collaborator Author

rbayet commented Feb 8, 2019 •
edited
Loading

TODO :

  • Unit testing.
  • test in context of search analytics module

@rbayet rbayet requested a review from romainruaud February 8, 2019 10:15
@rbayet rbayet force-pushed the feat-aggs-pipelines-and-filters branch 2 times, most recently from ad6ecb4 to 9b8a1f7 Compare February 8, 2019 17:19
@rbayet rbayet force-pushed the feat-aggs-pipelines-and-filters branch from 9b8a1f7 to d7f03e3 Compare February 12, 2019 09:49
@rbayet rbayet changed the title WIP: Aggregations: support for pipeline aggs and filter Aggregations: support for pipeline aggs and filter Feb 12, 2019
@romainruaud romainruaud merged commit 32b86e5 into Smile-SA:master Feb 12, 2019
@rbayet rbayet deleted the feat-aggs-pipelines-and-filters branch March 1, 2019 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romainruaud romainruaud romainruaud approved these changes

Assignees

@romainruaud romainruaud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rbayet @romainruaud