Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1186 - support web/js files relocation #1190

Merged
merged 1 commit into from
Nov 19, 2018

Conversation

rbayet
Copy link
Collaborator

@rbayet rbayet commented Nov 19, 2018

To be introduced in 2.3.x and 2.2.7
With expected BC break in 2.2.x because magento/magento2#16582 does not seem to cover this particular case
See issue of origin magento/magento2#16302

To be introduced in 2.3.x and 2.2.7
With expected BC break in 2.2.x because magento/magento2#16582 does not seem to cover this particular case
See issue of origin magento/magento2#16302
@romainruaud
Copy link
Collaborator

Seems ok since I saw it working on your env.

Could you just do a quick scan of potential other issues like this in other modules ? As far as I can remember, there should not be any other cases, but I prefer to ensure it before merging and closing this PR.

@rbayet
Copy link
Collaborator Author

rbayet commented Nov 19, 2018

Could you just do a quick scan of potential other issues like this in other modules ? As far as I can remember, there should not be any other cases, but I prefer to ensure it before merging and closing this PR.

Already did, this was the only occurence of "variableName: 'Mage_module/path/to/js" in the suite modules' requirejs-config.js.

@romainruaud
Copy link
Collaborator

Great !

I merge this one.

It replaces #1187

Please @wouter-toppershops test this one by using the 2.6.x branch.

@romainruaud romainruaud merged commit f94e917 into Smile-SA:2.6.x Nov 19, 2018
@wouter-toppy
Copy link
Contributor

Thanks, will try

@wouter-toppy
Copy link
Contributor

@rbayet it still gives the error on 2.3-beta.

@rbayet
Copy link
Collaborator Author

rbayet commented Nov 20, 2018

@wouter-toppershops hmmm yeah, the path mapping from old to new location has not been kept in 2.3.
If focused on the 2.2.x.
I'll revert the PR if I manage to have an hybrid version of the fix, both for 2.2.x and 2.3.

@rbayet rbayet deleted the fix_1186_form_mini_not_found branch December 11, 2018 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants