Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix relevance config save. #1137

Merged
merged 1 commit into from
Oct 17, 2018
Merged

Fix relevance config save. #1137

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/module-elasticsuite-core/Model/Search/Request/RelevanceConfig.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ class RelevanceConfig extends \Magento\Config\Model\Config
* @param StoreManagerInterface $storeManager Store Manager
* @param Containers $containersSource The Containers source model
* @param ScopePool $scopePool RelevanceConfiguration Scope Pool
* @param array $data The data
*/
public function __construct(
ReinitableConfigInterface $config,
Expand All @@ -71,11 +72,13 @@ public function __construct(
ValueFactory $configValueFactory,
StoreManagerInterface $storeManager,
Containers $containersSource,
ScopePool $scopePool
ScopePool $scopePool,
array $data = []
) {
$this->containersSource = $containersSource;
$this->fullConfig = true;
$this->scopePool = $scopePool;
$this->fullConfig = true;
$this->scopePool = $scopePool;

parent::__construct(
$config,
$eventManager,
Expand All @@ -85,6 +88,11 @@ public function __construct(
$configValueFactory,
$storeManager
);

// Mimic the call to \Magento\Framework\DataObject::__construct($data).
// $data parameter is intentionally omitted in parent::__construct() call because parent constructor is
// inconsistent between minor magento versions.
$this->_data = $data;
}

/**
Expand Down