Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for: RelevanceConfig isn't saving to DB #1077

Closed
wants to merge 3 commits into from

Conversation

pczerkas
Copy link
Contributor

RelevanceConfig changes in admin aren't saving to DB. This pull request fixes this.

@romainruaud
Copy link
Collaborator

Hello @pczerkas

how are your saving the relevance config ? Just by clicking save on the back-office ? or you are doing it programmatically ?

@pczerkas
Copy link
Contributor Author

pczerkas commented Oct 4, 2018

Hello @romainruaud

I've tried to save relevance config from the backend (it didn't work). But the fix f160773 is rather straightforward: it adds missing parameter for parent class constructor?

@romainruaud
Copy link
Collaborator

Replaced by #1137

Magento constructor differs between two minor versions 2.2.5 and 2.2.6 and the order for additional parameters in constructor is inconsistent ...

See https://github.com/magento/magento2/blob/2.2-develop/app/code/Magento/Config/Model/Config.php

They introduced $settingsChecker before $data which makes us unable to have a proper backward-compatible parent::__construct() call with the $data parameter inside.

@pczerkas
Copy link
Contributor Author

Super, thank you Romain!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants