-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace jquery/ui with the new modular approach #1590
Comments
Good catch @Quazz ! Any chance you provide some help on this one ? :) |
@romainruaud Haven't fully tested it, but as far as I can tell, just replace jquery/ui with jquery-ui-modules/widget in the following locations: I don't believe anything other than Widget is used of jquery-ui, but I could be mistaken. Haven't logged any complaints in the browser console so far, in the instances I could think of. Looking over the code, it seems to be accurate, too. Everything else seems to be handled by the other dependencies. |
@androshchuk can you check that the proposed replacement is working ? |
@romainruaud it's working. @Quazz thank you for your help. Regards |
BC with EE/CE M2 2.3.* to be tested. |
Perhaps the 'delegated dependency' that the tweet mentions is the better approach then?
|
@rbayet I checked way use Magento_Ui/js/modal/modal instead of jquery/ui in M2 CE 2.3.0 and M2 CE 2.3.3. Everything works fine. |
…-ui-module Feature #1590 replace jquery-ui with jquery-ui-module
Solved by PR #1597 |
Describe the solution you'd like
Replace each instance of jquery/ui dependency with the relevant modular approach.
The reason this is desirable is that it improves performance, especially on lower end devices. (less javascript to process is alway good!)
Additional context
Magento 2.3.3 changed jquery-ui to be split up into seperate modules. Extensions should now update their scripts to no longer depend on the bulky jquery-ui, but only the modules that it requires
Additional info can be found in this tweet: https://twitter.com/vova_yatsyuk/status/1182192753335324673?s=09
The text was updated successfully, but these errors were encountered: