Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 silence rake warnings about unused vars #95

Merged
merged 1 commit into from
Feb 21, 2018
Merged

🎨 silence rake warnings about unused vars #95

merged 1 commit into from
Feb 21, 2018

Conversation

jm3
Copy link
Contributor

@jm3 jm3 commented Dec 28, 2017

Silence rake warnings by prefixing unused vars with _.

smashing-1.1.0/lib/dashing/cli.rb:37: warning: assigned but unused variable - e
smashing-1.1.0/lib/dashing/cli.rb:53: warning: assigned but unused variable - http_error
smashing-1.1.0/lib/dashing/cli.rb:91: warning: assigned but unused variable - e
smashing-1.1.0/lib/dashing/app.rb:156: warning: assigned but unused variable - id

@terraboops terraboops merged commit 87ee353 into Smashing:master Feb 21, 2018
@terraboops
Copy link

When you're running tests I suppose? This probably came in with the ruby version upgrade recently.

Good catch! Thanks very much for your contribution, sorry for the merge delay.

@kinow kinow added this to the 1.2 milestone May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants