Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't display exception pages to users by default. #103

Merged
merged 1 commit into from
May 22, 2018

Conversation

YtvwlD
Copy link
Contributor

@YtvwlD YtvwlD commented May 3, 2018

No description provided.

@kinow
Copy link
Member

kinow commented May 18, 2018

I would have to test to confirm it works. But from the issue title, and looking at the single line changed, it sounds like a good idea.

@kinow
Copy link
Member

kinow commented May 19, 2018

Had some spare time, tried from the main branch, got the following by invalid syntax in the dashboard

screenshot from 2018-05-19 16-10-15

Then checked out this pull request, and it displayed just an internal server error.

screenshot from 2018-05-19 16-21-20

I think we would just need to document it, and perhaps having a flag to enable/disable it would be nice too. Wonder if we could have something like smashing start --trace.

@kinow
Copy link
Member

kinow commented May 19, 2018

Approving PR, but having @tylermauthe 's review here too before merging would be nice (: and thanks again @YtvwlD !

Copy link

@terraboops terraboops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can go either way @kinow - IMO Smashing dashboards are meant to be used by hackers, for hackers, so the audience should be chill about error pages... In other words, if you're showing Smashing dashboards to people who'll be upset about error pages you prolly ought to use something more professional anyway...

However, it's a small change and it's easy to revert if it's less well liked - so let's try it out.

@terraboops terraboops merged commit 4d5e645 into Smashing:master May 22, 2018
@YtvwlD YtvwlD deleted the dont-show-exceptions branch March 31, 2019 12:42
@kinow kinow added this to the 1.2 milestone May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants